[PATCH] D133709: -dot-machine-cfg for printing MachineFunction to a dot file

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:137
+    const BasicBlockT *Node,
+    llvm::function_ref<void(raw_string_ostream &, const BasicBlockT &)>
+        HandleBasicBlock,
----------------
Don't need llvm::


================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:139
+        HandleBasicBlock,
+    llvm::function_ref<void(std::string &, unsigned &, unsigned)>
+        HandleComment) {
----------------
Don't need llvm::


================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:187
   // Cache for is hidden property
   llvm::DenseMap<const BasicBlock *, bool> isOnDeoptOrUnreachablePath;
 
----------------
Don't need llvm::


================
Comment at: llvm/include/llvm/CodeGen/MachineCFGPrinter.h:70
+      const MachineBasicBlock *Node, DOTMachineFuncInfo *,
+      llvm::function_ref<void(raw_string_ostream &, const MachineBasicBlock &)>
+          HandleBasicBlock =
----------------
Don't need llvm::


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133709/new/

https://reviews.llvm.org/D133709