[PATCH] D134280: [NFC] refactor XCOFFObjectFile::getImportFileTable.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 06:41:14 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!

You mentioned in another ticket that using the new function could cause other error paths to be hit. That's fine, and I don't think you need to specifically test them for the new type that uses the function, but it does mean that this ticket isn't technically a `[NFC]` so shouldn't be labelled as such. You could say why it isn't NFC in the commit body, to explain why you haven't added additional testing, for example, if you want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134280/new/

https://reviews.llvm.org/D134280



More information about the llvm-commits mailing list