[PATCH] D134266: Introduce predicate for a atomic operations in GMIR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 06:17:28 PDT 2022


arsenm added a comment.

What's this going to be used for?



================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:395
+// Marker of end of Generic Atomic opcodes
+HANDLE_TARGET_OPCODE_MARKER(PRE_ISEL_GENERIC_ATOMIC_OPCODE_END, G_ATOMICRMW_FMIN)
+HANDLE_TARGET_OPCODE_MARKER(GENERIC_ATOMIC_OP_END, PRE_ISEL_GENERIC_ATOMIC_OPCODE_END)
----------------
yassingh wrote:
> sameerds wrote:
> > Why is this marker needed? Should OP_END be sufficient to pair with OP_START?
> Yes it's not, OP_START and OP_END should be sufficient, will update
Why doesn't G_FENCE count?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134266/new/

https://reviews.llvm.org/D134266



More information about the llvm-commits mailing list