[PATCH] D134142: [InstCombine] Handle integer extension in `select` patterns using the condition as value

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 06:13:43 PDT 2022


zero9178 updated this revision to Diff 461553.
zero9178 added a comment.

Address review comments:

- Consistently use `ConstantInt`
- Use `0` and `1` instead of `true` and `false` in comments, since it is now applicable to all integer types, not just `i1`
- Add test coverage for original motivating example. I only added the `zext/sext` and `sext/zext` cases, as the other cases are comparatively uniniteresting and were previously already handled by sinking of the casts below the select
- Precommit tests and rebase this patch on top of it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134142/new/

https://reviews.llvm.org/D134142

Files:
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/test/Transforms/InstCombine/select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134142.461553.patch
Type: text/x-patch
Size: 9625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220920/cabad7da/attachment.bin>


More information about the llvm-commits mailing list