[PATCH] D134073: [TableGen] Add useDeprecatedPositionallyEncodedOperands option.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/test/TableGen/InsufficientPositionalOperands.td:27
 
-// CHECK: Too few operands in record foo (no match for variable rs)
-  let OutOperandList = (outs Regs:$xd);
+// CHECK: No operand named rs in record foo
+  let OutOperandList = (outs Regs:$rd);
----------------
MaskRay wrote:
> Add `CHECK-NEXT: note: Dumping record for previous error:` then use `--implicit-check-not=error:`
> 
> Q: by changing `$xd`, do we lose test coverage by not testing an undefined operand name?
Done, and good point about losing test coverage. Switched this test to useDeprecatedPositionalOperands to preserve testing the positional error, and another test added for when positional matching is off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134073/new/

https://reviews.llvm.org/D134073