[PATCH] D133992: [objdump] Add --build-id flag for debuginfod lookups without binary.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Two nits, otherwise looks good.



================
Comment at: llvm/test/tools/llvm-objdump/debuginfod.test:40
+RUN: not env DEBUGINFOD_CACHE_PATH=%t llvm-objdump -d --source \
+RUN:   --build-id foo 2> %t.err
+RUN:   FileCheck %s --check-prefix=MALFORMEDERROR --input-file %t.err
----------------
On first glance, it wasn't clear why this one was malformed, and the next one is not found. Perhaps worth extending the comment here explaining how it is malformed (i.e. something like "not a hex string").


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:3061-3065
+  if (Is("otool"))
+    parseOtoolOptions(InputArgs);
+  else
+    parseObjdumpOptions(InputArgs);
+
----------------
Nit: to reduce git blame noise, you should be able to do this move as part of the change which introduces the debuginfod stuff, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133992/new/

https://reviews.llvm.org/D133992