[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 00:47:12 PDT 2022


xiangzhangllvm marked 11 inline comments as done.
xiangzhangllvm added inline comments.


================
Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:25
   __asm call kimport;
-  // CHECK:     calll   *({{.*}})
+  // CHECK:     calll   __imp__kimport
 
----------------
xiangzhangllvm wrote:
> pengfei wrote:
> > Why is it affected? Is missing a `*` before the label?
> The dllimport mark it is a inter linkage, so we can directly call this function.
typo: inter linkage --> internal linkage


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914



More information about the llvm-commits mailing list