[PATCH] D134211: [LV] Create createInductionResumeValue helper.
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 00:37:33 PDT 2022
Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.
LGTM, adding minor nits.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3179
+ for (BasicBlock *BB : BypassBlocks)
+ BCResumeVal->addIncoming(II.getStartValue(), BB);
----------------
nit: indent?
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3193
+ "Inconsistent information about additional bypass.");
+ DenseMap<const InductionDescriptor *, Value *> ResumeValues;
+ // We are going to resume the execution of the scalar loop.
----------------
Probably meant to collect all BCResumeVals created and return them, but is currently dead code - better leave for subsequent patch and out of this refactoring patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134211/new/
https://reviews.llvm.org/D134211
More information about the llvm-commits
mailing list