[PATCH] D122860: [RISCV][RVV] Add FPRndModeOp to PseudoVFCVT instructions

ShihPo Hung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 00:26:58 PDT 2022


arcbbb marked an inline comment as done.
arcbbb added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:9543
+    (void)HasSEW;
+    assert(HasVL && HasSEW);
+    Idx = MI.getNumExplicitOperands() - HasPolicy - 3;
----------------
fakepaper56 wrote:
> How about just call `hasVLOp` and `hasSEWOp` to avoid the two casts to `void`?
> ```
> assert(RISCVII::hasVLOp(TSFlags) && RISCVII::hasSEWOp(TSFlags));
> ```
I'll fix it. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122860/new/

https://reviews.llvm.org/D122860



More information about the llvm-commits mailing list