[PATCH] D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov accepted this revision.
alexander-shaposhnikov added subscribers: keith, thakis.
alexander-shaposhnikov added a comment.
This revision is now accepted and ready to land.

see a small nit above,  otherwise - looks good to me.
p.s. https://reviews.llvm.org/D119671 seems to be relevant, don't know the current status of that effort though.
It would be good to review/land D134250 <https://reviews.llvm.org/D134250> or D119671 <https://reviews.llvm.org/D119671>, alternatively i think it's reasonable to add a TODO (that we should add a test once ObjectYAML is ready) and commit this fix now. 
cc: @thakis , @keith



================
Comment at: llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.cpp:246
+  // and code signature.
+  auto linkEditUpdateOffset = [&Offset](size_t size) {
+    uint64_t PreviousOffset = Offset;
----------------
nit: size -> Size

p.s. I'd probably rename linkEditUpdateOffset -> updateOffset


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133974/new/

https://reviews.llvm.org/D133974