[PATCH] D134168: [RISCV] Make preferred alignment of PointerArgs for MemIntrinsic

Jiejie Rong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 20:30:12 PDT 2022


JojoR added a comment.

In D134168#3801800 <https://reviews.llvm.org/D134168#3801800>, @craig.topper wrote:

> The description doesn't clearly describe the effect of the patch. My understanding from reading the user of this function is that the alignment of allocas and global variables used by memcpy are increased in CodeGenPrepare. This results in less memory operations. In the case of 32-bit dhrystone, it looks like we have an explicit call to the memcpy library function. I guess by aligning the pointers we allow the source and dest to both be word_size aligned so we can use the full word copy loop?
>
> In my local testing for riscv64 this didn't seem to affect dhrystone performance.

Yes, my test is on the RV32.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134168/new/

https://reviews.llvm.org/D134168



More information about the llvm-commits mailing list