[PATCH] D134168: [RISCV] Make preferred alignment of PointerArgs for MemIntrinsic

Jiejie Rong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 20:11:24 PDT 2022


JojoR added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:12986
+    return false;
+  MinSize = 8;
+  PrefAlign = Align(Subtarget.getXLen() / 8);
----------------
jrtc27 wrote:
> This seems arbitrary. I'd expect at least XLEN / 8 here?
The caller has check this condition, set PrefAlign only the original is more smaller :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134168/new/

https://reviews.llvm.org/D134168



More information about the llvm-commits mailing list