[PATCH] D132055: [LoopInterchange][PR57148] Ensure LCSSA form after loop interchnange

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 19:56:25 PDT 2022


congzhe added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:575
 
+    if (!OuterLoop->isLCSSAForm(*DT))
+      llvm::formLCSSA(*OuterLoop, *DT, LI, SE);
----------------
bmahjour wrote:
> why not consider innerloop also?
Thanks for the comment! I've now used `formLCSSARecursively()` and removed the LCSSA assertion check for both inner and outer loops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132055/new/

https://reviews.llvm.org/D132055



More information about the llvm-commits mailing list