[PATCH] D133840: AMDGPU: Add a pass to rewrite certain undef in PHI

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 17:32:14 PDT 2022


ruiling added a comment.

In D133840#3800169 <https://reviews.llvm.org/D133840#3800169>, @arsenm wrote:

> I'm confused about problem this is trying to solve. Is this a correctness fix, or optimization? If it's a correctness fix this feels like the wrong way to address it

Yes, this is correctness fix to make the optimization changes (D132449 <https://reviews.llvm.org/D132449> D132450 <https://reviews.llvm.org/D132450>) work correctly. This also allows StructurizeCFG to skip structured CFG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133840/new/

https://reviews.llvm.org/D133840



More information about the llvm-commits mailing list