[PATCH] D133625: [mlir][MemRef] Simplify extract_strided_metadata(expand_shape)

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 17:25:05 PDT 2022


qcolombet updated this revision to Diff 461427.
qcolombet added a comment.

- Move the sizes and strides computations in their own helper functions

The buildExpansionFactors didn't pan out as well as I would have hoped because the expressions are too different when you factor dynamic size and/or strides in the mix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133625/new/

https://reviews.llvm.org/D133625

Files:
  mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp
  mlir/test/Dialect/MemRef/simplify-extract-strided-metadata.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133625.461427.patch
Type: text/x-patch
Size: 23376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220920/e2ee607d/attachment.bin>


More information about the llvm-commits mailing list