[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 16:50:40 PDT 2022
efriedma added a comment.
These patches are hard to review, yes; the reviewer has to go through and verify for each function that the substitutes you've written actually match the C library semantics. (It's very easy to make mistakes with that sort of thing.)
On that front, I'm pretty sure the NaN handling in your fmin/fmax implementations are wrong.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134136/new/
https://reviews.llvm.org/D134136
More information about the llvm-commits
mailing list