[PATCH] D134203: [PGO] Avoid assertion on degenerate profile

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 15:26:19 PDT 2022


xur added a comment.

This is an interesting example. When we design this, we assume there is at least one exit node in the function. And we create fake edges from exit node(s). This way we create a close graph.

For this case, we don't have an exit node and I think the function exits from a non-return call to "zeroexit". So the edge propagation will terminate incompletely.

I think this is a corner case but let me think how to handle this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134203/new/

https://reviews.llvm.org/D134203



More information about the llvm-commits mailing list