[llvm] 0cec96a - [RISCV] Manage the InQueue flag in insertvli correctly.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 14:28:46 PDT 2022


Author: Craig Topper
Date: 2022-09-19T14:28:22-07:00
New Revision: 0cec96ab250e59e666d225a3b47ddd6289a82339

URL: https://github.com/llvm/llvm-project/commit/0cec96ab250e59e666d225a3b47ddd6289a82339
DIFF: https://github.com/llvm/llvm-project/commit/0cec96ab250e59e666d225a3b47ddd6289a82339.diff

LOG: [RISCV] Manage the InQueue flag in insertvli correctly.

We were only setting this flag the first time we added the blocks
not when we mark them for revisiting.

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D134193

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
index 5d9bd2f675588..ade89e86cb753 100644
--- a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
+++ b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
@@ -1128,8 +1128,10 @@ void RISCVInsertVSETVLI::computeIncomingVLVTYPE(const MachineBasicBlock &MBB) {
   // Add the successors to the work list so we can propagate the changed exit
   // status.
   for (MachineBasicBlock *S : MBB.successors())
-    if (!BlockInfo[S->getNumber()].InQueue)
+    if (!BlockInfo[S->getNumber()].InQueue) {
+      BlockInfo[S->getNumber()].InQueue = true;
       WorkList.push(S);
+    }
 }
 
 // If we weren't able to prove a vsetvli was directly unneeded, it might still


        


More information about the llvm-commits mailing list