[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 13:35:18 PDT 2022


reames added a comment.

In D133443#3795603 <https://reviews.llvm.org/D133443#3795603>, @asb wrote:

> Everything that's in this patch looks good to me - it's just missing some simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an -invalid.s that shows a sensible error message being produced when the instructions have an argument).

You had me very confused at first as I'd written the valid tests - until I realized they'd been lost in the rebase.  Updated patch forthcoming.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133443/new/

https://reviews.llvm.org/D133443



More information about the llvm-commits mailing list