[PATCH] D134058: [lld-macho] Support -dyld_env

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 13:18:12 PDT 2022


oontvoo added inline comments.


================
Comment at: lld/MachO/Writer.cpp:849
 
+  if (!config->dyldEnvs.empty()) {
+    for (const auto &dyldEnv : config->dyldEnvs)
----------------
thakis wrote:
> thakis wrote:
> > no need for the if, the loop does 0 iterations if dyldEnvs is empty
> (not done?)
Done! (for real)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134058/new/

https://reviews.llvm.org/D134058



More information about the llvm-commits mailing list