[PATCH] D133923: [Release] Add bump-version script.

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 12:40:15 PDT 2022


ldionne added inline comments.


================
Comment at: llvm/utils/release/bump-version.py:176-178
+            # Before libc++ 16.x the version field was
+            # XXYZZ and after 16 it's XXYYZZ - figure out
+            # what we are dealing with by counting the numbers
----------------
ldionne wrote:
> ldionne wrote:
> > I suggest that you only check-in the version that handles `XXYZZ`, and I can modify this script in D134187.
> Ugh, sorry, I mean in the follow-up to D134187 that will change the scheme from `XXYZZ` to `XXYYZZ` (and update the docs, etc.).
The follow-up is D134209. Sorry for the numerous comments, but basically what I suggest is that you only handle `XXYZZ` in this script, and then I can modify this script again in D134209 to handle `XXYYZZ` (and only that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133923/new/

https://reviews.llvm.org/D133923



More information about the llvm-commits mailing list