[PATCH] D133923: [Release] Add bump-version script.

[Louis Dionne via Phabricator via llvm-commits]

ldionne added inline comments.


================
Comment at: llvm/utils/release/bump-version.py:174
+    def process_line(self, line: str) -> str:
+        if "define _LIBCPP_VERSION " in line:
+
----------------
This should be more future-proof in case e.g. clang-format causes this to change in the future. Then you can also use `t = match.group(1)` instead of `t = line[line.rfind(' ')+1:].strip()`, if you prefer that.


================
Comment at: llvm/utils/release/bump-version.py:176-178
+            # Before libc++ 16.x the version field was
+            # XXYZZ and after 16 it's XXYYZZ - figure out
+            # what we are dealing with by counting the numbers
----------------
I suggest that you only check-in the version that handles `XXYZZ`, and I can modify this script in D134187.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133923/new/

https://reviews.llvm.org/D133923