[PATCH] D134166: [MLGO] Add per-instruction MBB frequencies to regalloc dev features

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:1048
+                         const int MBBMappingIndex) {
+  size_t CurrentMBBIndex = VisitedMBBs[CurrentMBBName];
+  float CurrentMBBFreq = GetMBBFreq(CurrentIndex);
----------------
aidengrossman wrote:
> mtrofin wrote:
> > Why not use the MBB address?
> Give me a little bit of time to do some experimentation/investigation, but I tried calling `getSectionIDNum()` and utilizing that, but it would only return a single value for all the MBBs in the MF (only a single value would appear in the map).
I mean &MBB. I.e. `MachineBasicBlock*`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134166/new/

https://reviews.llvm.org/D134166