[PATCH] D123897: [X86] Unbreak LIT/FileCheck
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 12:08:10 PDT 2022
lebedev.ri added a reviewer: tonic.
lebedev.ri added a comment.
Alright. Well. I'm not //really// sure i should,
but it is possible that the time has come
to somewhat come back
from this reduced mental strain hiatus.
> <...>:
> • The commit message is approved by a member of the Code of Conduct response team.
I do believe that this has been addressed.
(i always use `arc patch`, so what is in phab, will be in the git log.)
> • All previous reviewer questions have been answered.
Assuming that we agree that the disscussion here did converge
on the need for this LIT change itself, i am under //impression//
that all the questions were answered. (audience can correct me)
> • All active approvers, or previous reviewers that requested changes have accepted the review.
That would be @tstellar - i believe those concerns were strictly about the textual description of the change, and those were addressed since.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123897/new/
https://reviews.llvm.org/D123897
More information about the llvm-commits
mailing list