[PATCH] D134164: [RelocationResolver] Add R_RISCV_SET8
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 10:44:15 PDT 2022
MaskRay added a comment.
Is there a test using this relocation type? We don't add unneeded ones.
================
Comment at: llvm/lib/Object/RelocationResolver.cpp:468
+ case ELF::R_RISCV_SET8:
+ return (A & 0x00) | ((S + RA) & 0xFF);
case ELF::R_RISCV_SUB6:
----------------
tschuett wrote:
> Is the `0x00` a typo or for symmetry?
`& 0xff` is needed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134164/new/
https://reviews.llvm.org/D134164
More information about the llvm-commits
mailing list