[llvm] 90a004b - [LV] Remove FIXME about NoImplicitFloat. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 10:01:15 PDT 2022


Author: Craig Topper
Date: 2022-09-19T10:01:02-07:00
New Revision: 90a004b4a14b27ba83a17734d439cfd8624db4b5

URL: https://github.com/llvm/llvm-project/commit/90a004b4a14b27ba83a17734d439cfd8624db4b5
DIFF: https://github.com/llvm/llvm-project/commit/90a004b4a14b27ba83a17734d439cfd8624db4b5.diff

LOG: [LV] Remove FIXME about NoImplicitFloat. NFC

My understanding is that NoImplicitFloat, despite it's name, is
supposed to disable all vectors not just float vectors.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D134084

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index d926cb5bdf21a..135052f1de281 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -10234,10 +10234,8 @@ bool LoopVectorizePass::processLoop(Loop *L) {
     }
   }
 
-  // Check the function attributes to see if implicit floats are allowed.
-  // FIXME: This check doesn't seem possibly correct -- what if the loop is
-  // an integer loop and the vector instructions selected are purely integer
-  // vector instructions?
+  // Check the function attributes to see if implicit floats or vectors are
+  // allowed.
   if (F->hasFnAttribute(Attribute::NoImplicitFloat)) {
     reportVectorizationFailure(
         "Can't vectorize when the NoImplicitFloat attribute is used",


        


More information about the llvm-commits mailing list