[PATCH] D134165: [llvm] prefix linker flag on non-MSVC compilers with `-Wl,`

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

@ashay-github, just to make sure I'm understanding the issue, this occurs when building with `clang`, not `clang-cl` correct?

If the issue occurs with `clang-cl`, that seems like a bug we should fix in the `clang-cl` driver.



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:133
       set(export_file_linker_flag "/DEF:\"${export_file_linker_flag}\"")
+    elseif(WIN32)
+      # If we're compiling on Windows and the compiler is not Visual Studio,
----------------
Does the same issue occur if you use compilers other than clang? I'm wondering if this change should be clang-specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134165/new/

https://reviews.llvm.org/D134165