[PATCH] D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users

[Anton Sidorenko via Phabricator via llvm-commits]

asi-sc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:2519
+  const RISCVInstrInfo &TII = *Subtarget->getInstrInfo();
+  for (SDNode::use_iterator UI = Node->use_begin(), UE = Node->use_end();
+       UI != UE; ++UI)
----------------
reames wrote:
> I request that you separate this patch into one which is one-use restricted, and then a second which adds the use walk.  The former patch would parallel what we do for e.g. insert_vector folds.  
@reames, do you think that use walk approach will introduce some regressions while one-use approach won't? I'll split the patch, it's not a problem, I'm just trying to understand what issue we are trying to solve by that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130895/new/

https://reviews.llvm.org/D130895