[PATCH] D133030: [AIX] llvm-readobj support a new option --exception-section for xcoff object file.
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 19 06:48:19 PDT 2022
DiggerLin marked an inline comment as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:455
+ SmallString<32> UnknownType;
+ Twine(("<Unknown:") + Twine::utohexstr(SectType) +">").toVector(UnknownType);
+ const char *SectionName = UnknownType.c_str();
----------------
jhenderson wrote:
> Do you need to add the `0x` explicitly? I haven't looked at `uthexstr`, so it might not need it, but I think we should have the 0x to make it clear it is in hex.
Twine::utohexstr will have "0x" as prefix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133030/new/
https://reviews.llvm.org/D133030
More information about the llvm-commits
mailing list