[PATCH] D134173: [LoopFuse] Drop loop dispositions before reassigning blocks to other loop

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 03:35:20 PDT 2022


mkazantsev added a comment.

In D134173#3799177 <https://reviews.llvm.org/D134173#3799177>, @fhahn wrote:

> In D134173#3799159 <https://reviews.llvm.org/D134173#3799159>, @mkazantsev wrote:
>
>> Keeping drop of these loop dispositions as a separate call generally looks increasingly annoying... I'll see if there is a way to get rid of it.
>
> Hmm, would it make sense to forget loop dispositions as part of forgetLoop? Having to clean them up separately is very easy to forget and also not really clear from the existing documentation.

I'd be fine with that, but depends on CT. Let's extinguish fire and try to measure it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134173/new/

https://reviews.llvm.org/D134173



More information about the llvm-commits mailing list