[PATCH] D134166: [MLGO] Add per-instruction MBB frequencies to regalloc dev features

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 01:01:10 PDT 2022


aidengrossman added a reviewer: mtrofin.
aidengrossman added a comment.

Here's the patch for the MBB based features. I've set it up in a way that isn't necessarily the most efficienct, but should allow for extra flexibility for experimentation on the ML side.  I've opted to set up the main MBB feature extraction function to get called at every loop iteration in the current per-instruction feature extraction code, but due to how we currently have unit testing setup, this adds a couple more parameters to that function and leaves things a little bit less elegant than they probably could be. I think this should be fine for now, but I can definitely refactor to a different paradigm if necessary, but figured it would be better to discuss solutions first (and see if it's even necessary) before doing that work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134166/new/

https://reviews.llvm.org/D134166



More information about the llvm-commits mailing list