[PATCH] D134156: [SCEV][NFC] Mark methods related to Loop Disposition computation as const

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 00:53:06 PDT 2022


nikic added a comment.

I'm not a fan of this -- I'd rather have the `const_cast` when you call this with `UseCache=false`. The thing is that SCEV caching is not at all transparent, it is order dependent and riddled with invalidation issues (as you know ^^), so pretending that that these are const does not feel right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134156/new/

https://reviews.llvm.org/D134156



More information about the llvm-commits mailing list