[PATCH] D133396: [MemorySSA] Don't do addr phi translation if addr value is not a loop invariant

[luxufan via Phabricator via llvm-commits]

StephenFan added inline comments.


================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1269
-
-          if (TransAddr &&
-              !IsGuaranteedLoopInvariant(const_cast<Value *>(TransAddr)))
----------------
These codes here seem to make sense. But deleting them would not cause any tests to fail. I think it is necessary to add test cases to cover it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133396/new/

https://reviews.llvm.org/D133396