[PATCH] D64835: [Xtensa 9/10] Add basic support of Xtensa disassembler.

Andrei Safronov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 18 18:46:46 PDT 2022


andreisfr added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/Disassembler/XtensaDisassembler.cpp:171
+
+/// Read four bytes from the ArrayRef and return 24 bit data sorted
+/// according to the given endianness.
----------------
saugustine wrote:
> this only reads three bytes, does it not? And no need to comment about the endianness--it isn't supported.
Corrected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64835/new/

https://reviews.llvm.org/D64835



More information about the llvm-commits mailing list