[PATCH] D134014: [NFC][SimplifyCFG]Precommit test case to show inner-loop metadata may not be preserved

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/preserve-llvm-loop-metadata.ll:1
-; RUN: opt -simplifycfg -simplifycfg-require-and-preserve-domtree=1 -keep-loops=false -S < %s | FileCheck %s
-; RUN: opt -passes='simplifycfg<no-keep-loops>' -S < %s | FileCheck %s
+; RUN: opt -opaque-pointers -simplifycfg -simplifycfg-require-and-preserve-domtree=1 -keep-loops=false -S < %s | FileCheck %s
+; RUN: opt -opaque-pointers -passes='simplifycfg<no-keep-loops>' -S < %s | FileCheck %s
----------------
davidxl wrote:
> is this related change?
This was added since 'test2' used opaque pointers.

The context is that, even if 'opt' tool uses opaque pointers by default, " opaque pointer mode is automatically disabled for IR and bitcode files that explicitly mention i8* style typed pointers." (from https://llvm.org/docs/OpaquePointers.html#opaque-pointers-mode)

Updated new tests to use i32* (and `-opaque-pointer` is not required), and will send out a separate patch to clean up this test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134014/new/

https://reviews.llvm.org/D134014