[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

[Shafik Yaghmour via Phabricator via llvm-commits]

shafik added inline comments.


================
Comment at: llvm/lib/Support/APFloat.cpp:4206
+  else if (Arg.isZero())
+    Result.makeInf(/* Negative = */ true);
+  else if (Arg.isInfinity())
----------------
This is the format as documented by clang-tidy bugprone argument comment see here: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html

IIRC it depends on strict mode but I would just avoid the whitespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134136/new/

https://reviews.llvm.org/D134136