[PATCH] D134076: RFC - [ADT] Ranges pipe syntax support + SFINAE

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 18 09:49:04 PDT 2022


kazu added a comment.

In D134076#3797962 <https://reviews.llvm.org/D134076#3797962>, @dblaikie wrote:

> Any chance you're interested in proposing this as part of a patch series to at least migrate some of the existing iterator-adaptor or custom algorithms to this usage? (@kazu - maybe this'd be of some interest to you too?)

I have thought about the ranges library.  If somebody posts patches in small chunks, I am happy to review them.  Otherwise, I am inclined to wait until we can use C++20, which should happen in 3 years or so because we just upgraded to C++17.  The reason for my lazy/passive approach is as follows.  I do like the expressiveness of the views with the "pipe" operator `|`, but it's mostly syntactic sugar that doesn't significantly reduce the token count -- `A | B | C` v.s. `C(B(A))`.

> I seem to recall some discussion about compile-time performance problems with view heavy code?

I see some posts on the Internet.  I'll read up on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134076/new/

https://reviews.llvm.org/D134076



More information about the llvm-commits mailing list