[PATCH] D134117: [Transforms] Merge function attributes within InlineFunction (NFC)

Sat Sep 17 22:29:19 PDT 2022

kazu added a comment.

In D134117#3797926 <https://reviews.llvm.org/D134117#3797926>, @davidxl wrote:

> Why not adding another parameter to InlineFunction method to specify whether attribute Merge is done?

Thank you for the review.  I've updated the patch.  Please take a look.

One concern is that I have to pass several default parameters before I can specify the last parameter.  Perhaps I could reorder the parameters to reduce the number default parameters to pass, but that should be left as a follow-up patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134117/new/

https://reviews.llvm.org/D134117