[PATCH] D134087: [TableGen] Track reference locations of Records/RecordVals

[Chris Lattner via Phabricator via llvm-commits]

lattner added a comment.

Very cool, it'd be great to improve this in tblgen!

I'm a long way from working on this code, but the representation is a bit odd.  Typically you'd put a location on `VarInit` when forming the `VarInit::get`.  Having a location on this would enable far better diagnostics across all of tblgen.

That said, it would make the jump to definition implementation slightly more awkward, because it has to scan the AST to find references, instead of having them on the declaration.  I'm concerned that taking a step like in this patch would be a sideways step for improving tblgen though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134087/new/

https://reviews.llvm.org/D134087