[PATCH] D134013: [lld][thinlto] Include -mllvm options in the thinlto cache key

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: lld/test/ELF/lto/cache.ll:65
+;; Changing order may matter - e.g. if overriding -mllvm options - so we get 2 more entries
+; RUN: ld.lld --thinlto-cache-dir=%t.cache -o %t3 %t2.o %t.o -mllvm -max-devirt-iterations=1 -mllvm -enable-ml-inliner=default
+; RUN: ls %t.cache | count 9
----------------
MaskRay wrote:
> Perhaps change on test to use `-plugin-opt=-max-...` for some variance.
huh, so it turns out `-plugin-opt=` is handled in a different way. Do we want to make the feature "force" --plugin-opt equivalence to -mllvm, or we're happy to treat them differently, and just validate that "it also works with --plugin-opt"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134013/new/

https://reviews.llvm.org/D134013