[PATCH] D132199: [LoopPassManager] Ensure to construct loop nests with the outermost loop

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

thanks, lgtm with one nit
sorry for the long back and forth

I do think that the loop nest infrastructure in general needs some work and doesn't fit in with the rest of the new pass manager infrastructure very well. there should have been an RFC (unless I missed it)



================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:365
+  /// loopnest has been modified.
+  void markIfLoopNestChanged(bool Changed) {
+    LoopNestChanged = Changed;
----------------
`markLoopNestChanged`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132199/new/

https://reviews.llvm.org/D132199