[PATCH] D133994: [BOLT] Change base class of ExecutableFileMemoryManager

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added inline comments.


================
Comment at: bolt/include/bolt/Rewrite/ExecutableFileMemoryManager.h:36
+  };
+  SmallVector<AllocInfo, 4> AllocatedSections;
+
----------------
maksfb wrote:
> maksfb wrote:
> > yota9 wrote:
> > > maksfb wrote:
> > > > yota9 wrote:
> > > > > It seems to me that 4 is not suitable number and might be increased significantly, maybe like 32 or even 64, what do you think?
> > > > In relocation mode, there are not that many sections emitted. I can bump it to 8.
> > > You're right it is too much, I was also thinking about debug sections, that might be around ~8 as I understand. But I don't insist here, thanks for bumping anyway :)
> > For now it’s only .debug_line come get from EFMM. 
> Sorry, sent that from my phone. Most debug sections we emit directly. For now, only `.debug_line` is emitted via MC and gets allocated by EFMM. Thanks for the review.
Thanks for clarifying and this change :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133994/new/

https://reviews.llvm.org/D133994