[PATCH] D134013: [lld][thinlto] Include -mllvm options in the thinlto cache key
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 16 13:01:19 PDT 2022
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM. I think fixing just ELF is fine, but will be great if you fix COFF/MachO/WebAssembly as well as follow-up patches.
I'd recommend some options more general and more common than `-mllvm -enable-ml-inliner=default -mllvm -max-devirt-iterations=1`, but using them is fine, too.
================
Comment at: lld/ELF/LTO.cpp:82
c.Options.EmitAddrsig = true;
+ for (const auto C : config->mllvmOpts)
+ c.MllvmArgs.emplace_back(C.str());
----------------
`const auto` => StringRef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134013/new/
https://reviews.llvm.org/D134013
More information about the llvm-commits
mailing list