[PATCH] D133999: [SelectOpti] Restrict load sinking

[Sotiris Apostolakis via Phabricator via llvm-commits]

apostolakis added inline comments.


================
Comment at: llvm/test/CodeGen/X86/select-optimize.ll:203
   %load = load i32, ptr %a, align 8
-  call void @llvm.lifetime.end.p0(i64 2, ptr nonnull %a)
   %x = add i32 %load, %b
   %sel = select i1 %cmp, i32 %x, i32 %y, !prof !17
----------------
davidxl wrote:
> For sunkable loads, should the lifetime marker still be preserved?
The lifetime-marker intrinsic writes to memory and thus there will not be any sunk loads bypassing lifetime markers.
This is why this patch also covers the use-after-free resolved by D133777.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133999/new/

https://reviews.llvm.org/D133999