[PATCH] D133845: [llvm] increase upper bound for size in global structs
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 16 12:39:27 PDT 2022
efriedma added a comment.
Maybe the commit message ("summary") could use a bit more description. I'm not sure what 9b1620a501c1 refers to, and I'm not sure it's relevant.
Since you don't have commit access, I'll commit this for you when it's ready. How do you want to be credited in the "author" field of the git commit? (name+email)
================
Comment at: llvm/test/CodeGen/X86/big-array-init.ll:5
+; CHECK-NEXT: .long 1
+; CHECK-NEXT: .zero 4294967292
+ at bad_int = global <{ i32, [1073741823 x i32] }> <{ i32 1, [1073741823 x i32] zeroinitializer }>, align 16
----------------
Maybe `CHECK-NEXT: .size bad_int, 4294967296`, to be on the safe side. (The current version of the test would pass on a release build without your patch.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133845/new/
https://reviews.llvm.org/D133845
More information about the llvm-commits
mailing list