[PATCH] D116702: [GlobalISel] Combine select + fcmp to fminnum/fmaxnum/fminimum/fmaximum

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 09:35:19 PDT 2022


arsenm added a comment.

In D116702#3678812 <https://reviews.llvm.org/D116702#3678812>, @foad wrote:

> Just curious: why do we need to do this in isel? Is there a reason it cannot or does not get done at the IR level?

I think this is one where we need both. First, selects are likely to appear out of legalization. Second, the IR doesn't have the full range of min/max opcodes (it doesn't have the _IEEE versions, and the intrinsics were incorrectly named)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116702/new/

https://reviews.llvm.org/D116702



More information about the llvm-commits mailing list