[PATCH] D133999: [SelectOpti] Restrict load sinking

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectOptimize.cpp:713
+  // Ensure that the instructions are on the same basic block.
+  if (LoadI->getParent() != SinkPt->getParent())
+    return false;
----------------
In most of the cases, the load and sinkpt are not in the same bb right -- as the case in the test case I commented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133999/new/

https://reviews.llvm.org/D133999