[PATCH] D133452: [ORC] Fix auto-claim of weak defs in ObjectLinkingLayer

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 07:51:23 PDT 2022


Hahnfeld added a comment.

In D133452#3782574 <https://reviews.llvm.org/D133452#3782574>, @lhames wrote:

> I think I botched the commit message for that commit and that might be contributing to the confusion: Prior to that commit any weak symbol that was //referenced in the graph//, but //wasn't// in the responsibility set was turned into an external symbol (not dead-stripped, as the commit message says). That would result in a missing definition error within the graph containing the definition. That was definitely a bug, and the original commit fixed that issue.

But then, what test case do I have to run to see the problem after reverting that commit locally?

> Can you share the IR that you're feeding in? I'd like to try to reproduce this and understand what's going on.

I posted the C++ code above, just compile with `clang++ -target riscv64-unknown-linux-gnu -S -emit-llvm throw.cpp`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133452/new/

https://reviews.llvm.org/D133452



More information about the llvm-commits mailing list