[PATCH] D133972: [AMDGPU] Fix size of SOPK instructions to 4 bytes

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D133972#3793361 <https://reviews.llvm.org/D133972#3793361>, @Joe_Nash wrote:

> I believe you are correct about SOPK being fixed size. This looks like it could be an NFC change, because the code below would detect if there was a literal used. If you have any reason to think its not NFC, please add a test. That said, I think a better way to do the change is set FixedSize = 1 on SOPP_Pseudo.

Right, FixedSize was originally introduced (D25500 <https://reviews.llvm.org/D25500>) as a special case for instructions that are known not to have a literal operand even though the InOperandList contains something unusual that might look like a literal. It should not be needed in general for all instructions that happen to have a fixed size. So it would be nice to know what unusual case prompted this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133972/new/

https://reviews.llvm.org/D133972