[PATCH] D134006: Add an optional cache to computeKnownBits.

[Nikita Popov via Phabricator via llvm-commits]

nikic added reviewers: nikic, fhahn.
nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:41
+#include "third_party/llvm/llvm-project/llvm/include/llvm/Analysis/ValueTracking.h"
+#include "third_party/llvm/llvm-project/llvm/include/llvm/Support/KnownBits.h"
 #include "llvm/ADT/DenseMap.h"
----------------
Incorrect include paths


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:52
+// We can key lookups on the basic block that contains CxtI, rather than on CxtI
+// itself, because the context instr itself is not significant, only its BB.
+using KnownBitsCache = DenseMap<
----------------
This is incorrect, the context instruction is used to check applicability of assumes for example, see isValidAssumeForContext().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134006/new/

https://reviews.llvm.org/D134006